Contao Open Source CMS > Contao forum

Switch to german forum

Index > Feature request > MD5 checksum to check if installation is up to date

DimaTX
User
Avatar
I think TYPOlight updater could benefit from a mechanism that compares the checksum (of each file) of the current installation versus official TYPOlight releases. This would allow administrators to verify that the update was successful and if not to see which files may have differences.

Also it would help administrators remember which files need to be backed up before update by checking their installation against the checksum of the last update applied. The updater could for instance warm the user that certain files that are about to be overwritten are not identical to the checksum of the current version.

What do you guys think?
2007-08-07 03:12
Ben
Partner
Avatar
Posts: 2126
Atlanta, Georgia, United States
Dima,

Leo has some kinda big changes coming up with the live update feature. I think your suggestion is a very good idea ... maybe he'll consider it.
2007-08-07 04:03
DimaTX
User
Avatar
Sounds good Ben,

I am looking forward to those big changes :)
2007-08-07 04:05
leo
Administrator
Avatar
Posts: 7044
Wuppertal, Germany
Hi Dima,

there is a little problem with the checksum idea: Windows server use CRLF and Unix servers use LF only. If I would publish a checksum list, it would only work for Unix servers (since we do not use Windows servers at all).

Regards
Leo
2007-08-07 10:17
Well it actually doesn't matter, you may use LF only on Windows server as well.
2007-08-07 10:42
leo
Administrator
Avatar
Posts: 7044
Wuppertal, Germany
Hi Scare,

I do know this ;-)

However, a lot of users download TYPOlight to their local Windows PC and upload the files via FTP. Unless this is done in binary mode, the FTP programm or server adjusts the type of line feed (probably depending on the local settings). And I really do not want to have two different versions (Windows and Unix).

Regards
Leo
2007-08-07 11:06
Then just get rid of CR before computing md5 (now that sounds nerdy :) )
2007-08-07 11:39
leo
Administrator
Avatar
Posts: 7044
Wuppertal, Germany
Hi Scare,

TYPOlight contains about 1.200 files.

iconCode:
for ($i=0; $i<1200; $i++)
{
    if (md5_file(...) != $array['file_i'])
    {
        ....
    }
}

compared to

iconCode:
for ($i=0; $i<1200; $i++)
{
    $file = file_get_contents(...);
    $file = str_replace("\r", "", $file);

    if (md5($file) != $array['file_i'])
    {
        ....
    }
}

Which solution will be faster (and how much memory will the second solution require)?

Regards
Leo
2007-08-07 12:06
That was a rhetorical question, I suppose :)

I have another idea. An installation script. Something like live update, but it would download and unpack complete installation package, so nobody would need to use ftp anymore.
2007-08-07 14:44
leo
Administrator
Avatar
Posts: 7044
Wuppertal, Germany
Hi Scare,

iconscare:
That was a rhetorical question, I suppose

it was indeed ;-)

I like the idea of the installer script that automatically downloads the files. I have also seen this before in a commercial online shop application. However, this is a very traffic consuming way of releasing a software and sourceforge.net does not allow this kind of services on their website. BTW, a few people are having issues with the live update because they are using a proxy server - they were not able to download TYPOlight at all.

Regards
Leo
2007-08-07 17:02
Bumping this thread..

Anyone knows if the topic of this discussion has been implemented somehow?


Anyway, I think it would be good to have a little tool that inspects the installation for missing or outdated files. When installing/upgrading typolight by ftp, there is the possibility that some files gets corrupted or not uploaded at all. I have had this issue several times.

Actually, once, after doing a live update from the backend, some files where not updated and I got some major errors with my installation. After several hours, inspecting error logs etc, I tried to manually update some files, and then I finally got it to work.

So, according to my own experience, doing a manual update, and in some rare cases also the live update, can end up with corrupt/missing files.

A check tool that inspects the installation would be a huge timesaver when something gets wrong with the installation. And I also think that a lot of topics about typolight errors in the forum would be gone.

As discussed, I understand that a tool like this is that easy to build. But it would be a great tool! B)
2009-06-01 14:09